Re: [PATCH v2 0/4] MR8564: cfgmgr32: Device query API part 3: Implement DevGetObjectProperties(Ex) and HDEVQUERY device updates.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/main.c:
> -static HRESULT dev_object_iface_get_props( DEV_OBJECT *obj, HDEVINFO set, SP_DEVICE_INTERFACE_DATA *iface_data,
> -
>                                       ULONG props_len, const DEVPROPCOMPKEY *props, BOOL all_props )
>
> +static HRESULT dev_object_iface_get_props( ULONG *props_len, DEVPROPERTY **props, HDEVINFO set,
> -
>                                       SP_DEVICE_INTERFACE_DATA *iface_data, ULONG propkeys_len,
> -
>                                       const DEVPROPCOMPKEY *propkeys, BOOL all_props )
>
> {
>      DEVPROPKEY *all_keys = NULL;
>      DWORD keys_len = 0, i = 0;
>      HRESULT hr = S_OK;
> - obj->cPropertyCount = 0;
> - obj->pProperties = NULL;
> - *props_len = 0;
> - *props = NULL;
> if (!props && !all_props)
>     return S_OK;

Especially as renaming the variables causes oversights like here.