Re: [PATCH v3 0/2] MR9094: rometadata: Add stub + tests for IMetaDataTables

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/rometadata/tests/rometadata.c:
> -
>            if (!strcmp(str, "Windows.Foundation.Metadata"))
> -
>            {
> -
>                guid_ctor_idx = ((i + 1) << 3) | 3;
> -
>                winetest_pop_context();
> -
>                break;
> -
>            }
> -
>        }
> -
>    }
> -
> -
>    winetest_pop_context();
> - }
> -
> - todo_wine
> - ok(!!guid_ctor_idx, "got guid_ctor_coded_idx %lu\n", guid_ctor_idx);
> -
> - /* Verify ITest1 has the correct GuidAttribute value. */

This is a lot of code to verify just one aspect of metadata. I think it's fine as a way to exercise the IMetadata interface but it doesn't really scale to verifying all aspects of metadata files.