Re: [PATCH v3 0/4] MR5741: server: Implement key auto-repeat.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about server/protocol.def:
> @REPLY
>      obj_handle_t handle;       /* next thread handle */
>  @END
> -
> -
>
> +/* Setup keyboard auto-repeat */
> +@REQ(set_keyboard_repeat)
> - int enable;                /* whether to enable auto-repeat */
> - int delay;                 /* auto-repeat delay in ms */
> - int period;                /* auto-repeat period in ms */
>
> +@REPLY
> - int enable;                /* previous state of auto-repeat enable */
> - int delay;                 /* previous auto-repeat delay in ms */
> - int period;                /* previous auto-repeat period in ms */

If it's not going to be useful in the short term (and as this MR don't use them I would say they aren't) I think it's better to remove the return values and only add them when it will be.