On Tue May 20 13:37:03 2025 +0000, Jinoh Kang wrote:
I'm not sure whether this is correct. In https://testbot.winehq.org/JobDetails.pl?Key=158356, I printed both `frame` and `!!(flags & RDW_FRAME)` and sometimes they are different. (This is for `RDW_VALIDATE` case only. I haven't seen such discrepancy between the two parameters for `RDW_INVALIDATE`).
They were different yes, because flags before this change, `flags |= RDW_FRAME` was done before calling redraw_window for the children only in the `(flags & RDW_INVALIDATE)` case, while frame was set to 1.
However, in the `!(flags & RDW_INVALIDATE)` case `flags & RDW_FRAME` is also not used for anything so it can be used to carry the information the frame parameter was carrying before, which makes `flags & RDW_FRAME` consistent over every use case.