[PATCH v5 7/7] vkd3d-shader/hlsl: Propagate swizzle chains.

[Francisco Casas]

From: Francisco Casas

---
 libs/vkd3d-shader/hlsl_codegen.c        | 38 +++++++++++++++++++++++++
 tests/swizzle-constant-prop.shader_test | 12 ++++----
 2 files changed, 44 insertions(+), 6 deletions(-)

diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c
index 9aa59612..746b65d3 100644
--- a/libs/vkd3d-shader/hlsl_codegen.c
+++ b/libs/vkd3d-shader/hlsl_codegen.c
@@ -1350,6 +1350,43 @@ static bool lower_narrowing_casts(struct hlsl_ctx *ctx, struct hlsl_ir_node *ins
     return false;
 }

+static bool propagate_swizzle_chains(struct hlsl_ctx *ctx, struct hlsl_ir_node *instr, void *context)
+{
+    struct hlsl_ir_swizzle *swizzle;
+    struct hlsl_ir_node *next_val;
+    unsigned int combined_swizzle;
+
+    if (instr->type != HLSL_IR_SWIZZLE)
+        return false;
+    swizzle = hlsl_ir_swizzle(instr);
+
+    next_val = swizzle->val.node;
+    combined_swizzle = swizzle->swizzle;
+
+    while (next_val->type == HLSL_IR_SWIZZLE)
+    {
+        combined_swizzle = hlsl_combine_swizzles(hlsl_ir_swizzle(next_val)->swizzle,
+                combined_swizzle, instr->data_type->dimx);
+        next_val = hlsl_ir_swizzle(next_val)->val.node;
+    }
+
+    if (next_val != swizzle->val.node)
+    {
+        struct hlsl_ir_swizzle *new_swizzle;
+        struct hlsl_ir_node *new_instr;
+
+        if (!(new_swizzle = hlsl_new_swizzle(ctx, combined_swizzle, instr->data_type->dimx, next_val, &instr->loc)))
+            return false;
+
+        new_instr = &new_swizzle->node;
+        list_add_before(&instr->entry, &new_instr->entry);
+        hlsl_replace_node(instr, new_instr);
+        return true;
+    }
+
+    return false;
+}
+
 static bool remove_trivial_swizzles(struct hlsl_ctx *ctx, struct hlsl_ir_node *instr, void *context)
 {
     struct hlsl_ir_swizzle *swizzle;
@@ -2787,6 +2824,7 @@ int hlsl_emit_bytecode(struct hlsl_ctx *ctx, struct hlsl_ir_function_decl *entry
         progress = transform_ir(ctx, hlsl_fold_constant_exprs, body, NULL);
         progress |= transform_ir(ctx, hlsl_fold_constant_swizzles, body, NULL);
         progress |= copy_propagation_execute(ctx, body);
+        progress |= transform_ir(ctx, propagate_swizzle_chains, body, NULL);
         progress |= transform_ir(ctx, remove_trivial_swizzles, body, NULL);
     }
     while (progress);
diff --git a/tests/swizzle-constant-prop.shader_test b/tests/swizzle-constant-prop.shader_test
index e9aa52a4..944d8702 100644
--- a/tests/swizzle-constant-prop.shader_test
+++ b/tests/swizzle-constant-prop.shader_test
@@ -26,7 +26,7 @@ draw quad
 probe all rgba (110, 210, 410, 410)

-[pixel shader todo]
+[pixel shader]
 Texture2D tex;
 uniform int i;

@@ -40,11 +40,11 @@ float4 main() : sv_target

[test]
 uniform 0 int 3
-todo draw quad
-todo probe all rgba (105, 5, 305, 305)
+draw quad
+probe all rgba (105, 5, 305, 305)

-[pixel shader todo]
+[pixel shader]
 Texture2D tex;
 uniform int i;

@@ -56,5 +56,5 @@ float4 main() : sv_target

[test]
 uniform 0 int 1
-todo draw quad
-todo probe all rgba (14.0, 14.0, 14.0, 14.0)
+draw quad
+probe all rgba (14.0, 14.0, 14.0, 14.0)