Re: [PATCH v4 0/2] MR711: vkd3d-shader/ir: Introduce a better CFG structurizer, part 6.

[Conor McCarthy (＠cmccarthy)]

Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
>                      vkd3d_unreachable();
>              }
>
> -
>            if (!reserve_instructions(&cfg->instructions, &cfg->ins_capacity, cfg->ins_count + 1))
> -
>            if (!reserve_instructions(&cfg->instructions, &cfg->ins_capacity, cfg->ins_count + 2))
>                return VKD3D_ERROR_OUT_OF_MEMORY;
>
> -
>            if (opcode == VKD3DSIH_BREAK || opcode == VKD3DSIH_BREAKP)
> -
>            {
> -
>                if (!vsir_instruction_init_with_params(cfg->program, &cfg->instructions[cfg->ins_count],
> -
>                        &no_loc, VKD3DSIH_MOV, 1, 1))
> -
>                    return VKD3D_ERROR_OUT_OF_MEMORY;
> -
> -
>                dst_param_init_temp_uint(&cfg->instructions[cfg->ins_count].dst[0], cfg->jump_target_temp_idx);
> -
>                src_param_init_const_uint(&cfg->instructions[cfg->ins_count].src[0], jump_target);

This is virtualisation, right? I wonder if there will be issues with older drivers, like we found with the TGSM MR. I don't the tests there will trigger this case.