Re: [PATCH v3 0/5] MR6917: windows.networking.connectivity: Implement IConnectionProfile::GetNetworkConnectivityLevel().

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.networking.connectivity/network_information.c:
> static HRESULT WINAPI network_information_statics_GetInternetConnectionProfile( INetworkInformationStatics *iface, IConnectionProfile **value )
>  {
> - FIXME( "iface %p, value %p stub!\n", iface, value );
> - return E_NOTIMPL;
> - NetworkConnectivityLevel network_connectivity_level;
> - struct connection_profile *impl;
> - HRESULT hr;
> -
> - TRACE( "iface %p, value %p\n", iface, value );
> -
> - *value = NULL;
> - if (FAILED(hr = get_connectivity_level( &network_connectivity_level ))) return hr;
> - if (network_connectivity_level == NetworkConnectivityLevel_None) return S_OK;

Fwiw I would have split `get_connectivity_level` separately from the commit which introduces a stub IConnectionProfile. It would have temporarily returned an object even with `NetworkConnectivityLevel_None` but I think it would be better as the meaningful changes would be kept separate.