Re: [PATCH v2 0/1] MR1395: dbghelp: Add SymAddrIncludeInlineTrace stub.

[Mohamad Al-Jaf (＠maljaf)]

On Fri Nov 18 04:11:28 2022 +0000, eric pouech wrote:
> Hi
> - could you rather put the implementation in symbol.c near the other
>
> inline context related functions?
> (at the end, just above SymSrvGetFileIndexInfo)?
> 2) is this the only DbgHelp's symbol missing for the app?
> thanks

Hi,

1. Sure
2. It looks that way, yeah. The user who reported this issue said it only happens when they click on the "People" button in the app. They said this stub fixes the crash and haven't reported any other issue since then. But it's always possible that they just haven't stumbled upon an unimplemented call from features they haven't used.

https://github.com/ValveSoftware/Proton/issues/6320

Thanks for the review!