On Sun Feb 16 16:38:49 2025 +0000, eric pouech wrote:
nitpick: IMO it's more readable to return a RETURN_CODE, and pass a DIRECTORY_STACK** to update the pointer (you likely did it this way to minimize change, but let's take the opportunity of a change to sanitize a bit the current spaghetti code)
It is *always* my philosophy to minimize changes to existing, working code. Some projects emphasize this. I also come from a working assumption, perhaps erroneously, that existing code is functional and already meets project standards. No one likes to come into a project to add contributions and then have to get out the mop bucket to clean up legacy technical debt. I'm speaking generally here and not specifically about this particular part of code.