Re: [PATCH 0/3] MR269: vkd3d-shader/tpf: Combine struct sm4_dst_register and struct sm4_src_register.

[Francisco Casas (＠fcasas)]

On Mon Jul 10 17:45:18 2023 +0000, Henri Verbeet wrote:
> This seem like the wrong way to go about it. In particular, I think this
> is what we should do:
> - Make struct sm4_register a proper subset of struct
>
> vkd3d_shader_register. E.g. by changing the "type" field from
> vkd3d_sm4_register_type to vkd3d_shader_register_type. It probably also
> implies moving some fields from struct sm4_register to struct sm4_dst_register/sm4_src_register.
> - Replace usage of struct sm4_register with usage of struct
>
> vkd3d_shader_register. That should be straightforward after the previous step.
> - Move up from there. I.e., doing the same thing for struct
>
> sm4_dst_register, struct sm4_src_register, and struct sm4_instruction.
> It's possible that this will require adding things to the
> vkd3d_shader_instruction structures; that's fine.

Roger!