6 Feb
2024
6 Feb
'24
3:45 a.m.
On Tue Feb 6 03:15:17 2024 +0000, Kartavya Vashishtha wrote:
changed this line in [version 7 of the diff](/wine/wine/-/merge_requests/5020/diffs?diff_id=97820&start_sha=c739d0dbece9e9ded9f8d61dc366a24f28175991#6c845445f68f8d3b54ba3798c9bb9e781b28b2ec_602_605)
"const PCWSTR" is "const WCHAR *const", which differs from "const WCHAR *" in that the pointer variable itself can't be mutated. We don't usually bother with that in Wine, although I can't say I've seen such patches rejected either.
Unrelatedly, in general we avoid those typedefs; it's clearer just to spell out e.g. "const WCHAR *".