Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c:
if (!(sync_event = get_sync_event())) return -1;
- params = malloc( sizeof(int) + len );
- ret_addr = malloc( len );
- if (addr->sa_family == AF_UNIX && *addr->sa_data)
Accessing sa_data in this way is convenient, but looks wrong. I'd rather just see the cast to sockaddr_un written out anyway.