Re: [PATCH v2 0/22] MR4445: ntdll: Unwind the kernel stack on thread exit.

[Alexandre Julliard (＠julliard)]

On Tue Nov 21 19:56:19 2023 +0000, Rémi Bernon wrote:
> I'm not sure to understand why you removed the sp info here (vs not in
> the i386 / x86_64 dispatchers) and why you didn't include it in user_mode_abort_thread?
> Is it because it's not been modified before, and so we assume that the
> default and implicit rule of `.cfi_val_offset %sp,0`, or old sp == cfa
> (or whatever it is) is still valid?
> Feels a bit brittle if that ever changes isn't it? Especially in the ARM
> dispatchers where we could add intermediate user stack CFI like on x86.

old_sp == cfa is the default, I don't think it's useful to specify it explicitly. TBH I'm not sure I see a reason to do it on x86 either.