On Tue Jan 2 17:38:41 2024 +0000, Zsolt Vadász wrote:
applied the same fix to getenv() and added tests, although i'm not sure if they're sufficient enough.
the first patch is supposed to pass the tests without the second applied
so you need a todo_wine clause in from of the failing tests in first patch, and to remove it in second patch when the fix is applied
I'll let @piotr decide on how far we need the tests to go. A few remarks (don't take them for granted until Piotr jumps in)
* we can either have dedicated function to test case sensitvity (or the lack thereof) as you did, or we could insert these bits in the existing ones, by adding (or modifying) a new test with case sensitivity * I'm not fully convinced we need to test all the APIs. at least one per ANSI/UNICODE family is needed to ensure that we don't break things. it would be surprising that getenv and putenv have different case sensitivity. We don't tend to 100% coverage in the tests