Re: [PATCH v4 0/5] MR1635: jscript: Implement a Garbage Collector to deal with circular references.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/jscript.h:
> void heap_pool_free(heap_pool_t*) DECLSPEC_HIDDEN;
>  heap_pool_t *heap_pool_mark(heap_pool_t*) DECLSPEC_HIDDEN;
>
> +/* Initialize to zero before use */
> +struct heap_stack {
> - struct heap_stack_chunk *chunk;
> - struct heap_stack_chunk *next;
> - unsigned idx;
>
> +};
> -
>
> +HRESULT heap_stack_push(struct heap_stack*,void*) DECLSPEC_HIDDEN;
> +void *heap_stack_pop(struct heap_stack*) DECLSPEC_HIDDEN;

This is not really generic nor used outside GC, I'd suggest to make it private to GC and not have it in the header at all.