Re: [PATCH v2 0/1] MR4133: mfmediaengine: Don't send event notify when engine is shutdown.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
>  if (FAILED(hr))
>      WARN("Failed to create source object, hr %#lx.\n", hr);
>
> - if (engine->flags & FLAGS_ENGINE_SHUT_DOWN)
> - {
> -
>    LeaveCriticalSection(&engine->cs);
> -
>    TRACE("Engine is shut down, stopping...\n");
> -
>    IUnknown_Release(object);
> -
>    return S_OK;
> - }
> -

No, that's not what I meant. This way you still send MF_MEDIA_ENGINE_EVENT_LOADSTART contrary to what patch subject says. I meant checking for shutdown flags right after grabbing the lock, the same way it's done for public methods.