Re: [PATCH v2 0/5] MR310: hlsl: Define some intrinsics in HLSL.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.c:
> {
>      struct vkd3d_string_buffer *string;
>      struct hlsl_ir_var *var;
> -
>
> static LONG counter;
>
> if (!(string = hlsl_get_string_buffer(ctx)))
>     return NULL;
> -
>
> vkd3d_string_buffer_printf(string, "<%s-%u>", template, InterlockedIncrement(&counter));
> - vkd3d_string_buffer_printf(string, "<%s-%u>", template, ctx->internal_name_counter++);

This made me notice that we don't verify the return value for `vkd3d_string_buffer_printf()`. And apparently it's endemic in vkd3d-shader, so I can't really blame it on you, but maybe it makes sense to start rectifying it? The same happens in 4/5.