On Tue Mar 12 04:10:54 2024 +0000, Conor McCarthy wrote:
Is `begin` always the header block? If so, is `header` a better name? Similarly, if `end` is always the merge block, can we call it `merge`?
I think it's true that `begin` always end up begin the header block and `end` ends up begin the merge block, but at this level I find it more useful to think these numbers as positions (or times) at which the given interval begins or ends. The algorithm introduced in this MR handles intervals intervals in what I would describe as a "geometric" way, caring very little about what they mean in terms of the SPIR-V program that will eventually be generated. The concepts of header and merge blocks are introduced by SPIR-V at a later stage and feel unnecessary to me here. So I wouldn't change the names here.