Re: [PATCH v38 0/6] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/wintypes/tests/propertyset.c:
> - }
> -
> - hr = IPropertySet_QueryInterface( propset, &IID_IMap_HSTRING_IInspectable, (void **)&map );
> - todo_wine ok( SUCCEEDED( hr ), "QueryInterface failed, got %#lx\n", hr );
> - if (FAILED( hr ))
> - {
> -
>    RoUninitialize();
> -
>    return;
> - }
> -
> - hr = IPropertySet_QueryInterface( propset, &IID_IObservableMap_HSTRING_IInspectable,
> -
>                                  (void *)&observable_map );
> - IPropertySet_Release( propset );
> - todo_wine ok( SUCCEEDED( hr ), "QueryInterface failed, got %#lx\n", hr );
> -
> - if (map)

You already check that IPropertySet_QueryInterface( propset, &IID_IMap_HSTRING_IInspectable, (void **)&map ); should succeed and return directly when failed. So I don't think map can be NULL here.