Re: [PATCH v2 0/3] MR1033: winhttp: Add a few websocket options.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/winhttp/request.c:
>  int bytes_sent;
>  DWORD ret, len;
>
> - if (request->flags & REQUEST_FLAG_WEBSOCKET_UPGRADE
> -
>    && request->websocket_set_send_buffer_size < MIN_WEBSOCKET_SEND_BUFFER_SIZE)
> - {
> -
>    WARN( "Invalid send buffer size %u.\n", request->websocket_set_send_buffer_size );
> -
>    ret = ERROR_NOT_ENOUGH_MEMORY;
> -
>    goto end;
> - }

This isn't pretty. If websocket_set_send_buffer_size exists only to return this error and your app doesn't depend on this then I'd rather leave this out.