On Fri Oct 25 22:59:56 2024 +0000, Fabian Maurer wrote:
To make sure we'd need to do it for all "normal" saves where we can use `xmlSaveSetIndentString` and then all places that call `xmlNodeDumpOutput` directly and indirectly. That could be a bunch of places, including `node_get_xml`, in our office case. This could easily lead to a regression if we miss one place. Do we want to go that route?
Looks like the recommended replacement is not xmlTreeIndentString - that one will be deprecated as well in libxml >= 2.14. The recommended replacement is configuring the save context, using a function that doesn't exist until 2.14. https://gitlab.gnome.org/GNOME/libxml2/-/commit/35146ff31cfc4698050e4500b267...
For now, this MR looks like a good approach to me. The function is not deprecated in libxml2 2.12.8, we can ignore the issue until the next libxml2 upgrade.
(Also looks like I suck at reading libxml2 source code. xmlSaveSetIndentString has been deprecated for five months, not two years.)