On 10/16/22 20:26, Paul Gofman wrote:
I think at very least we should keep correct Win ABI and performance as a priority. E. g., if we can express the unwind through syscall dispatcher with CFI we can do that, but IMO building this whole thing around Valgrind is wrong. Maybe there are other ways to do it, keeping Valgrind solely on the Unix part (I don’t know if that is possible). Or maybe we can develop some parts for the tool which will explicitly support Wine specifics.
Sure, I definitely agree with that part. I don't think we should sacrifice performance in the case that valgrind isn't enabled, but I do think we should try to make sure it works in at least some configuration. (And if that means using different code paths based on RUNNING_ON_VALGRIND, so be it...)