Re: [PATCH 0/4] MR8908: wbemprox: Add MSFT_PhysicalDisk table and improve class_object_Next().

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c:
> -
>    if (drives & (1 << i))
> -
>    {
> -
>        root[0] = 'A' + i;
> -
>        type = GetDriveTypeW( root );
> -
>        if (type != DRIVE_FIXED && type != DRIVE_REMOVABLE) continue;
> -
> -
>        if (!resize_table( table, row + 1, sizeof(*rec) )) return FILL_STATUS_FAILED;
> -
> -
>        get_freespace( root, &size );
> -
>        rec = (struct record_msft_phys_disk *)(table->data + offset);
> -
>        rec->adapter_serial_number = NULL;
> -
>        rec->allocated_size = size;
> -
>        rec->bus_type = type == DRIVE_FIXED ? 17 /* NVME */: 1 /* USB */;
> -
>        rec->cannot_pool_reason = NULL;
> -
>        rec->can_pool = -1;
> -
>        rec->description = NULL;

You can skip the zero assignments, tables are zero-initialized. Also, aligning '=' like in other table implementations would make it more readable IMO.