Rémi Bernon (@rbernon) commented about include/dxcore_interface.h:
- */
+#ifndef __DXCORE_INTERFACE__ +#define __DXCORE_INTERFACE__
+#include <stdarg.h> +#include <stdint.h> +#include <ole2.h>
+#ifdef __cplusplus +#define REFLUID const LUID & +#else +#define REFLUID const LUID * +#endif
+typedef enum DXCoreAdapterProperty
In C++ these are `enum class`, which is different from `enum` as the value won't be in the global namespace and you'd have to do `DXCoreAdapterProperty::InstanceLuid` for instance.
However, C doesn't have `enum class` and we want the headers to be compatible with our C code, so I suggest maybe doing something like:
```suggestion:-0+0 #ifdef __cplusplus #define DECLARE_ENUM_CLASS(x) enum class x #else #define DECLARE_ENUM_CLASS(x) typedef enum x x; enum x #endif
DECLARE_ENUM_CLASS(DXCoreAdapterProperty) { ... }; ```