On Tue Nov 19 08:23:09 2024 +0000, Hans Leidekker wrote:
Your test shows that calling MsiSummaryInfoPersist() has no effect if the database is transacted. That makes sense because changes should only be stored when MsiDatabaseCommit() is called. It would be nice if you could add a test that shows this. Then the commit message 'Fix MsiSummaryInfoPersist not saving data to disk' should be more specific. Your patch only handles the case where MsiGetSummaryInformationW() opens the database.
Thanks, changed the commit message and added another test using MsiDatabaseCommit to persistent the changes using a transacted database.