Re: [PATCH v2 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/winhttp/winhttp_private.h:
>  REQUEST_RESPONSE_STATE_READ_RESPONSE_QUEUED,
>  REQUEST_RESPONSE_STATE_REQUEST_SENT,
>  REQUEST_RESPONSE_STATE_READ_RESPONSE_QUEUED_REQUEST_SENT,
> - REQUEST_RESPONSE_STATE_REPLY_RECEIVED,
> - REQUEST_RESPONSE_STATE_READ_RESPONSE_QUEUED_REPLY_RECEIVED,
> REQUEST_RESPONSE_RECURSIVE_REQUEST,
> REQUEST_RESPONSE_STATE_RESPONSE_RECEIVED,

"winhttp: Only read server reply in send_request() if the whole request is sent." would be a better title for this patch. It won't block this patch but I still think that the state machine is overly complex. I suspect that a model where we always queue but synchronize when the request is synchronous or when it is opportune would simplify this.