Re: [PATCH v2 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.

[Mohamad Al-Jaf (＠maljaf)]

Mohamad Al-Jaf (@maljaf) commented about dlls/windows.system.profile.systemmanufacturers/main.c:
> -
>
> static HRESULT WINAPI statics_get_SerialNumber( ISmbiosInformationStatics *iface, HSTRING *value )
>  {
> - FIXME( "iface %p, value %p stub!\n", iface, value );
> - return E_NOTIMPL;
> - BSTR serial = NULL;
> - HSTRING ret;
> - HRESULT hr;
> -
> - TRACE( "iface %p, value %p.\n", iface, value );
> -
> - hr = get_bios_system_serial( &serial );
> - if (FAILED(hr))
> - {
> -
>    WARN( "Failed to get serial number, returning 0.\n" );
> -
>    serial = strdupAW("0");

This could be changed to use wcsdup instead. But is it considered good practice having a fallback or should the function just fail completely if it fails to get a serial number using wbemprox?

```suggestion:-0+0
        serial = wcsdup(L"0");
```