1 Apr
2025
1 Apr
'25
4:46 p.m.
On Tue Apr 1 16:08:20 2025 +0000, Piotr Caban wrote:
This change will break similar test in msvcp90:
diff --git a/dlls/msvcp90/tests/ios.c b/dlls/msvcp90/tests/ios.c index 91da0b91dd8..eb4febeb57b 100644 --- a/dlls/msvcp90/tests/ios.c +++ b/dlls/msvcp90/tests/ios.c @@ -2586,7 +2586,9 @@ static void test_time_get__Getint(void) time_get_char time_get; int i, ret, v; + memset(&time_get, 0xcc, sizeof(time_get)); call_func1(p_time_get_char_ctor, &time_get); + trace("--> %Ix\n", time_get.facet.refs);It looks like locale_facet was changed but only in msvcp140 version (I didn't check anything except msvcp90 and msvcp140, what version it changed in needs to be verified).
The attached ad-hoc test suggests it changed in msvcp110:
``` ios.c:2609: Test failed: got the same function. ios.c:2612: msvcp90.dll --> 0 ios.c:2612: msvcp100.dll --> 0 ios.c:2612: msvcp110.dll --> cccccccc00000000 ios.c:2612: msvcp120.dll --> cccccccc00000000 ios.c:2612: msvcp140.dll --> cccccccc00000000 ``` [test.patch](/uploads/96789ca97822c1b317a306b80802b98b/test.patch)
I guess I will update the structure definition accordingly.