Subject: [PATCH 1/6] wined3d: Move the min filter fixup from wined3d_sampler_desc_from_sampler_states() to wined3d_texture_gl_apply_sampler_desc().That effectively removes it from the sampler objects path though. I suspect conditional NP2 and sampler objects are effectively mutually exclusive, but is that an intentional change? The commit message doesn't explicitly mention it, at least.
Yes, I don't know why I thought that was correct. Perhaps I misread ARB_sampler_objects as implying GL 3.2, but it doesn't.
Subject: [PATCH 3/6] wined3d: Handle texture LOD in wined3d_sampler_desc_from_sampler_states().It's probably fine, but note that this could potentially increase the number of unique sampler objects being created.
Yes, I suppose we could avoid that by passing it as a standalone state (à la sample mask). I don't know whether that's worthwhile at this point.
Didn't we get rid of that not that long ago? It's probably not terrible, but it seems slightly nicer to me to call wined3d_stateblock_invalidate_texture_lod() (that's the main purpose of this, right?) from ddraw/d3d8/d3d9.
I don't feel strongly about it, but this is easier and doesn't require adding a new export, and I feel like sharing common logic in wined3d is an improvement?