Re: [PATCH 4/7] winegstreamer: Leave async reader callback_cs on calloc error.

[Zebediah Figura (she/her)]

On 8/22/22 12:26, Rémi Bernon wrote:
> diff --git a/dlls/winegstreamer/wm_asyncreader.c b/dlls/winegstreamer/wm_asyncreader.c
> index 6f4aa303d82..222ed84bd95 100644
> --- a/dlls/winegstreamer/wm_asyncreader.c
> +++ b/dlls/winegstreamer/wm_asyncreader.c
> @@ -290,7 +290,10 @@ static HRESULT async_reader_queue_op(struct async_reader *reader, enum async_op_
>       EnterCriticalSection(&reader->callback_cs);
>   if (!(op = calloc(1, sizeof(*op))))
> - {
> -
>    LeaveCriticalSection(&reader->callback_cs);
>     return E_OUTOFMEMORY;
> - }
>  op->type = type;
>  op->new_context = context;

I think it'd make more sense to limit the scope of the mutex to the 
list_add_tail() call.