Re: [PATCH 0/1] MR1604: vbscript: Make redim fail on fixed-size arrays.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/tests/run.c:
> -
>    ok(pdp->rgvarg != NULL, "rgvarg == NULL\n");
> -
>    ok(!pdp->rgdispidNamedArgs, "rgdispidNamedArgs != NULL\n");
> -
>    ok(pdp->cArgs == 1, "cArgs = %d\n", pdp->cArgs);
> -
>    ok(!pdp->cNamedArgs, "cNamedArgs = %d\n", pdp->cNamedArgs);
> -
>    ok(pvarRes != NULL, "pvarRes == NULL\n");
> -
>    ok(V_VT(pvarRes) == VT_EMPTY, "V_VT(pvarRes) = %d\n", V_VT(pvarRes));
> -
>    ok(pei != NULL, "pei == NULL\n");
> -
> -
>    ok(V_VT(pdp->rgvarg) == (VT_VARIANT|VT_BYREF), "Unexpected argument type %d.\n", V_VT(pdp->rgvarg));
> -
>    v = V_VARIANTREF(pdp->rgvarg);
> -
>    ok(V_VT(v) == (VT_VARIANT|VT_ARRAY|VT_BYREF), "Unexpected argument type %d.\n", V_VT(v));
> -
>    if (V_ISARRAY(v))
> -
>    {
> -
>        SAFEARRAY *sa = V_ISBYREF(v) ? *V_ARRAYREF(v) : V_ARRAY(v);
> -
>        is_fixed = (sa->fFeatures & (FADF_FIXEDSIZE | FADF_STATIC)) == (FADF_FIXEDSIZE | FADF_STATIC);
> -
>        sa->fFeatures &= ~FADF_FIXEDSIZE;

Is modifying fFeatures a leftover from some experimenting?