On Fri Aug 25 18:10:16 2023 +0000, Bartosz Kosiorek wrote:
Could you verify what kind of error (if any) is returned in test case? You could investigate how to create such test case by analysing: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/win32u/dib.c#L1221 It would be really useful, as with current implementation we are changing default behavior.
@gang65 Returning an error here is an implementation detail. I don't even know that native uses GetDIBits. I do know that this implementation does, and something reasonable should be done when a bad value is returned.
Finding conditions that cause native to break and testing those is one thing, but unless you have something specific in mind already, I don't see the need for additional testing here.