On Fri May 19 21:57:43 2023 +0000, Zebediah Figura wrote:
This seems very complicated, especially this deref manipulation. I'm rather tempted to propose that we just leave off handling anything but top-level sm1 variables for an hlsl_fixme(). For that matter, do we even have anything that actually needs this combined-sampler logic?
It's true it's a bit intricate (not that I know of any better way to do the same thing), but I don't think we should drop it. I know we already discussed that, but to me whether a feature is used somewhere or not shouldn't be a criterion to decide whether to have that feature or not (it can be a reasonable criterion to decide on what to concentrate development). In theory our shader compiler should be able to compile any shader that is accepted by the native compiler.