On 9/27/22 06:14, Jacek Caban (@jacek) wrote:
Jacek Caban (@jacek) commented about tools/widl/header.c:
fprintf(header, "#ifndef __%s__\n", header_token); fprintf(header, "#define __%s__\n\n", header_token);
- fprintf(header, "#ifndef __WIDL_INLINE\n");
- fprintf(header, "#if defined(__cplusplus) || defined(_MSC_VER)\n");
- fprintf(header, "#define __WIDL_INLINE static inline\n");
- fprintf(header, "#elif defined(__GNUC__)\n");
- fprintf(header, "#define __WIDL_INLINE static __inline__\n");
- fprintf(header, "#endif\n\n");
Do we really need __WIDL_INLINE? It seems to me that we could just use static inline unconditionally.
For Wine, we can, but "inline" isn't C89, and my understanding is that mingw-w64 would like to maintain c89 compatiblity (and widl is shared with mingw-w64). Cf. [1].
[1] https://sourceforge.net/p/mingw-w64/mailman/message/37685824/