Huw Davies (@huw) commented about dlls/advapi32/tests/registry.c:
/* Test simple key load */ /* Check if the changes are saved */ ret = RegLoadAppKeyA(hivefilepath, &appkey, KEY_READ | KEY_WRITE, 0, 0);
- ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret);
- ok(appkey != NULL, "got a null key\n");
- todo_wine ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret);
- todo_wine ok(appkey != NULL, "got a null key\n");
I'd suggest swapping the order of these commits so that you don't end up having to flip-flop these `todo_wine`s.
Also note that there's now no need to add the Signed-off-by tags.