Re: [PATCH v2 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/filter.l:
> +#include <stdio.h>
> -
>
> +#include "msado15_private.h"
> +#include "filter.tab.h"
> -
>
> +#include "wine/debug.h"
> -
>
> +WINE_DEFAULT_DEBUG_CHANNEL(msado15);
> -
>
> +%}
> -
>
> +%%
> -
>
> +[ \r\t]         { /* ignore all whitespace */ } ;
> +[0-9]+.[0-9]+ 	{ yylval->fval = atof(yytext); return T_FLOAT; }
> +[-]?[0-9]+      { yylval->ival = atoi(yytext); return T_INT;   }

That minus sign doesn't need to be in brackets.

Should this check if the integer is out of range?

Should hexadecimal or octal numbers be handled? The latter is particularly important.