I guess that with this pass the `hlsl_fixme()`'s in `write_sm4_resource_load()` and `write_sm4_resource_store()` can be promoted to `assert()`'s?
Yes, at least for the `hlsl_type_is_resource()` checks. The `var->is_uniform` checks should remain in place, in case there are still unhandled cases where resources can be components of parameters).
Also, but very minor: I don't feel the verb "promote" is really appropriate here. To me "promotion" usually means we're somehow playing with types, but no type is involved here. Maybe "split" would be more appropriate?
I see. In the new version the function no longer exists though.