Re: [PATCH 0/2] MR4817: shell32: Implement some functions of IFileOperation.

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/shell32/shlfileop.c:
> -
> -
>        ret = new_item(ptr->pTo, ptr->pNewName, ptr->attributes, operations);
> -
> -
>        if (ptr->pNewName) free((void*)ptr->pNewName);
> -
>        if (ptr->pTo) free((void*)ptr->pTo);
> -
>        if (ptr->pTemplateName) free((void*)ptr->pTemplateName);
> -
>        list_remove(&ptr->entry);
> -
>        continue;
> -
>    }
> -
> -
>    shfoW.wFunc = ptr->wFunc;
> -
>    shfoW.pFrom = ptr->pFrom;
> -
>    shfoW.pTo = ptr->pTo;
> -
> -
>    ret = SHFileOperationW(&shfoW);
> -
>    operations->fAnyOperationsAborted = shfoW.fAnyOperationsAborted;

If fAnyOperationsAborted is already TRUE, this could change it to FALSE, which I don't think we want.