Re: [PATCH v2 0/4] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.

[Connor McAdams (＠cmcadams)]

Connor McAdams (@cmcadams) commented about dlls/setupapi/devinst.c:
>      if (req_size)
>          *req_size = size;
>  }
> - else if (IsEqualDevPropKey( *prop_key, DEVPKEY_Device_HardwareIds )
> -
>         || IsEqualDevPropKey( *prop_key, DEVPKEY_Device_CompatibleIds ))
> - {
> -
>    DWORD prop = IsEqualDevPropKey( *prop_key, DEVPKEY_Device_HardwareIds ) ? SPDRP_HARDWAREID : SPDRP_COMPATIBLEIDS, size = 0;
> -
>    if (!SetupDiGetDeviceRegistryPropertyW( devinfo, device_data, prop, NULL, buf, buf_size, &size ))

Like the earlier commit, newline after variable declaration (same for the else if below) :)

Also, splitting these commits up to only address one `DEVPKEY` at a time would make this easier to review and probably help regression testing. I.e, 3 separate commits, one for `DEVPKEY_Device_HardwareIds`, the next for `DEVPKEY_Device_CompatibleIds`, and then the final one for `DEVPKEY_Device_ContainerId`.