Nikolay Sivov (@nsivov) commented about dlls/mf/session.c:
if (FAILED(hr = IMFMediaEventGenerator_EndGetEvent(event_source, result, &event))) { WARN("Failed to get event from %p, hr %#lx.\n", event_source, hr);
goto failed;
IMFMediaEventQueue_QueueEventParamVar(session->event_queue, MEError, &GUID_NULL, hr, &value);IMFMediaEventGenerator_Release(event_source);return hr;
MEError is supposed to indicate fatal non-recoverable error. Have you checked what happens if you get this condition in the middle of the playback for example? I suspect such error reporting should happen in many more places, and we can work on this later, but right now it's useful to figure out if session gets into error state when this happens. Could you check what happens if End/BeginGetEvent() fails suddenly after a number of samples was successfully delivered and playback is still active? Should we stop the clock when this happens? Should we send first fatal error event only, or following failures are always reported with MEError?
Note that 'value' is passed here uninitialized, if it's unused I believe you can use NULL.