Re: [PATCH 0/4] MR3329: winsock: Better cancel asyncs when socket handle is closed.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/afd.c:
> -
>    {FALSE, TRUE, NULL, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {TRUE,  TRUE, NULL, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {FALSE, FALSE, NULL, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {TRUE,  FALSE, NULL, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {FALSE, TRUE, test_async_thread_termination_apc, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {TRUE,  TRUE, test_async_thread_termination_apc, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {FALSE, FALSE, test_async_thread_termination_apc, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {TRUE,  FALSE, test_async_thread_termination_apc, NULL, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {FALSE, TRUE, NULL, (void *)0xdeadbeef, TEST_CLOSE_OTHER_BEFORE_THREAD_EXIT},
> -
>    {TRUE,  TRUE, NULL, (void *)0xdeadbeef, TEST_CLOSE_OTHER_BEFORE_THREAD_EXIT},
> -
>    {FALSE, FALSE, NULL, (void *)0xdeadbeef, TEST_CLOSE_OTHER_BEFORE_THREAD_EXIT},
> -
>    {TRUE,  FALSE, NULL, (void *)0xdeadbeef, TEST_CLOSE_OTHER_BEFORE_THREAD_EXIT},
> -
>    {FALSE, TRUE, test_async_thread_termination_apc, (void *)0xdeadbeef, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {TRUE,  TRUE, test_async_thread_termination_apc, (void *)0xdeadbeef, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {FALSE, FALSE, test_async_thread_termination_apc, (void *)0xdeadbeef, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},
> -
>    {TRUE,  FALSE, test_async_thread_termination_apc, (void *)0xdeadbeef, TEST_CLOSE_OTHER_AFTER_THREAD_EXIT},

It might be worth doing a nested loop at least for the close type where there are 3 options.