On Wed Aug 9 07:39:30 2023 +0000, Rémi Bernon wrote:
If you want to put it in a separate commit, it should probably come first, with the field addition and the `WindowsDeleteString` call. Otherwise when `device_statics2_CreateWatcher` was used, `Release` will call `WindowsDeleteString` on destruction with an invalid filter (though perhaps zero-initialized HSTRING is valid, but imho it'd be better that way).
Putting it in the same commit is fine. Like you said, I thought it was valid to call `WindowsDeleteString` with a NULL HSTRING since it just returns S_OK, but if it's better this way then it's fine.