Re: [PATCH v3 0/2] MR3301: Improve trace output

[Jeffrey Smith (＠whydoubt)]

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c:
> - "NameGivenName",
> - "NameSurname"
>
> +};
> -
>
> +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat)
> +{
> - if (NameFormat >= sizeof(string_NameFormat)/sizeof(string_NameFormat[0]))
> -
>    return "(unknown)";
> - return string_NameFormat[NameFormat];
>
> +}
> -
>
> BOOLEAN WINAPI GetUserNameExW(
>    EXTENDED_NAME_FORMAT NameFormat, LPWSTR lpNameBuffer, PULONG nSize)
>  {
> - TRACE("(%d %p %p)\n", NameFormat, lpNameBuffer, nSize);
> - TRACE("(%d %s %p %p)\n", NameFormat, debugstr_NameFormat(NameFormat), lpNameBuffer, nSize);

Written this way, it would make it appear that the function takes 4 parameters.  I would suggest revising to make it clear that this is two representations of the same parameter.