Re: [PATCH v2 0/1] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/wldap32/tests/parse.c:
> -
> - ret = ldap_deleteA( NULL, NULL );
> - ok( ret == (ULONG)-1, "ldap_deleteA should fail, got %#lx\n", ret );
> - ret = ldap_deleteA( NULL, (char *)"" );
> - ok( ret == (ULONG)-1, "ldap_deleteA should fail, got %#lx\n", ret );
> - ret = ldap_deleteA( ld, NULL );
> - ok( ret != (ULONG)-1, "ldap_deleteA should succeed, got %#lx\n", ret );
> - ret = ldap_deleteA( ld, (char *)"" );
> - ok( ret != (ULONG)-1, "ldap_deleteA should succeed, got %#lx\n", ret );
> -
> - ret = ldap_delete_sA( NULL, NULL );
> - ok( ret == LDAP_PARAM_ERROR, "ldap_delete_sA should fail, got %#lx\n", ret );
> - ret = ldap_delete_sA( NULL, (char *)"" );
> - ok( ret == LDAP_PARAM_ERROR, "ldap_delete_sA should fail, got %#lx\n", ret );
> - ret = ldap_delete_sA( ld, NULL );
> - flaky_wine ok( ret == LDAP_UNWILLING_TO_PERFORM, "ldap_delete_sA should fail, got %#lx\n", ret );

I don't think we want to introduce flaky tests for these edge cases. If there's an application that depends on this then it would be better to fix Wine/OpenLDAP.