Matteo Bruni (@Mystral) commented about dlls/d3d10/effect.c:
- if (FAILED(hr = parse_dxbc(data, data_size, fxlvm_chunk_handler, &context)))
return hr;
- if ((ret = vkd3d_shader_parse_dxbc(&dxbc, 0, &dxbc_desc, NULL)) < 0)
- {
WARN("Failed to parse DXBC, ret %d.\n", ret);
return E_FAIL;
- }
- for (i = 0; i < dxbc_desc.section_count; ++i)
- {
section = &dxbc_desc.sections[i];
if (FAILED(hr = fxlvm_chunk_handler(section, &context)))
break;
- }
- vkd3d_shader_free_dxbc(&dxbc_desc);
The value of 'hr' isn't used afterwards, it should probably be returned at the end of the function.