On Tue Jun 10 18:24:16 2025 +0000, Jinoh Kang wrote:
Makefile.in SOURCES generation is done automatically by `make_makefiles`. Auto-generated changes should not be a part of a patch proposed for upstream.[^1] [^2] [^1]: [Wineserver § Help to create a server request](https://wiki.winehq.org/Wineserver#Help_to_create_a_server_request), WineHQ wiki: "As with all generated files, the files generated by make_requests shouldn't be included in your patch. [^2]: [Re: [PATCH] server: Allow skipping debug handle retrieval in get_process_debug_info.](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.org/messag...), wine-devel Mailing List Archives: "Also, we do not include automatically generated changes (make_requests) in the patches, they are generated during upstream commit."
Where did this advice come from exactly? I've never heard Alexandre request that people not include generated files, only that it's not necessary, and I've seen plenty of patches accepted with generated changes. As far as I can tell "it's not necessary" got somehow warped into "you shouldn't" and then spread as common knowledge.