On Wed Oct 26 05:39:19 2022 +0000, Zebediah Figura wrote:
Agreed in general. I think the phrasing I'd use is "entry in hlsl_ctx->types", but I'm not picky.
Thinking again, I wouldn't dislike a phrasing that distinguishes the container entry from the item entry (typing makes it already clear for RB trees, but not for lists). So maybe something like "Container entry in hlsl_ctx->types" here and "Item entry in hlsl_type->entry" in `hlsl_ctx`. The "direction" of the containment relationship is usually not hard to infer from the context, but if you're reading a struct for the first time sparing some mind cycles can be helpful.