Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/msstyles.c:
/* Not found? Load from resources */ img = malloc(sizeof(*img)); img->image = LoadImageW(tc->hTheme, szFile, IMAGE_BITMAP, 0, 0, LR_CREATEDIBSECTION);
- prepare_alpha (img->image, hasAlpha);
- if (!has_default_transparent_colour)
has_default_transparent_colour = &has_default_trans;
- prepare_alpha (img->image, hasAlpha, has_default_transparent_colour); img->hasAlpha = *hasAlpha;
- img->has_default_transparent_colour = *has_default_transparent_colour;
Let's write it like the following. It's clearer this way.
``` prepare_alpha(img->image, &img->hasAlpha, &img->hasDefaultTransparentColour); if (hasAlpha) *hasAlpha = img->hasAlpha; if (has_default_transparent_colour) *has_default_transparent_colour = img->has_default_transparent_colour; ```