On Wed Jun 14 05:47:50 2023 +0000, Rémi Bernon wrote:
Looks okay, with the comments above about shm_open and to my very limited knowledge of Wayland. Also, some additional comment about the commit split, though at this point it's probably not much a big deal: Both https://gitlab.winehq.org/wine/wine/-/merge_requests/2944/diffs?commit_id=8d... and https://gitlab.winehq.org/wine/wine/-/merge_requests/2944/diffs?commit_id=ca... fix a broken corner case that has been introduced by the commit before them. In general I think it's better to avoid introducing broken intermediate state.
Thanks @rbernon! I felt that the split was beneficial, for review purposes at least, in order to focus on the edge cases and better justify solutions. I am fine squashing the "fix-corner-case" commits with their previous commits for the final merge if preferred.