Re: [PATCH 0/4] MR2928: xmllite/writer: Implement more APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> - FIXME("%p %s\n", This, wine_dbgstr_w(pwszName));
> - TRACE("%p %s\n", iface, wine_dbgstr_w(pwszName));
> - switch (This->state)
> - if (is_empty_string(pwszName))
> -
>    return E_INVALIDARG;
> -
> - while (*p)
> - {
> -
>     if (!is_ncnamechar(*p))
> -
>         return WC_E_NAMECHARACTER;
> -
> -
>     count++;
> -
>     p++;
> - }

This does not look right. It probably should use https://www.w3.org/TR/xml/#NT-Name or similar, e.g. you should not be able to start with a dot.